New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added request script logs #2041
Conversation
Visit the preview URL for this PR (updated for commit aa024d9): https://altair-gql--pr2041-imolorhe-add-request-9n2tqvbc.web.app (expires Sat, 26 Nov 2022 23:49:32 GMT) Sign: 02d6323d75a99e532a38922862e269d63351a6cf |
@@ -192,12 +202,22 @@ export class PreRequestService { | |||
}, | |||
importModule: (moduleName: string) => this.importModuleHelper(moduleName), | |||
response: this.buildContextResponse(data), | |||
log: (d: any) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@imolorhe just curious, but since this log
override is in pre-request.service.ts
, does a similar change need to be make to post-request.service.ts
?
The post-request tab is where personally I'm doing "post process & console.log".
That said, I'm just naively scanning the PR, so if the post-request tab ends up getting this functionality as well, then nevermind/np! Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a preview link in the PR. You can always test the change there post-request.service.ts
. We just have the pre-request.service.ts
which powers both. I just haven't renamed it since post requests were introduced.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Just tested it and it looks great!
Added request script logs
Checks
yarn test-build
Changes proposed in this pull request: