chore: remove duplicate selectors and enable stylelint rule #365
Conversation
|
| Name | Link |
|---|---|
| b7342d5 | |
| https://app.netlify.com/sites/new-eslint/deploys/6364b2f06860430008dabd86 | |
| https://deploy-preview-365--new-eslint.netlify.app | |
Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
|
| Name | Link |
|---|---|
| b7342d5 | |
| https://app.netlify.com/sites/ja-eslint/deploys/6364b2f0e327b900092be225 | |
| https://deploy-preview-365--ja-eslint.netlify.app | |
Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
|
| Name | Link |
|---|---|
| b7342d5 | |
| https://app.netlify.com/sites/es-eslint/deploys/6364b2f025572d000838c11d | |
| https://deploy-preview-365--es-eslint.netlify.app | |
Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
|
| Name | Link |
|---|---|
| b7342d5 | |
| https://app.netlify.com/sites/hi-eslint/deploys/6364b2f02a46900009c34d07 | |
| https://deploy-preview-365--hi-eslint.netlify.app | |
Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
|
| Name | Link |
|---|---|
| b7342d5 | |
| https://app.netlify.com/sites/pt-br-eslint/deploys/6364b2f02b5140000964433f | |
| https://deploy-preview-365--pt-br-eslint.netlify.app | |
Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
|
| Name | Link |
|---|---|
| b7342d5 | |
| https://app.netlify.com/sites/zh-hans-eslint/deploys/6364b2f006c66e00088debd4 | |
| https://deploy-preview-365--zh-hans-eslint.netlify.app | |
Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
|
| Name | Link |
|---|---|
| b7342d5 | |
| https://app.netlify.com/sites/fr-eslint/deploys/6364b2f00183300008e1304f | |
| https://deploy-preview-365--fr-eslint.netlify.app | |
Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
|
| Name | Link |
|---|---|
| b7342d5 | |
| https://app.netlify.com/sites/de-eslint/deploys/6364b2f0a84c3b0009574964 | |
| https://deploy-preview-365--de-eslint.netlify.app | |
Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
|
This is not auto fix but a manual one. I went through selectors and put them to a diff checker and removed common ones. |
There was a problem hiding this comment.
I'm not sure about a lot of these changes because the change the order in which properties are assigned and overridden. This isn't just about making sure that selectors aren't duplicated, it's also about making sure the cascade is working correctly. There are a lot of places where variables and properties are being overridden by @media blocks later, so moving properties from below @media blocks to above or vice versa actually changes the meaning of the CSS.
Please go back through and double-check that the order for these properties is correct.
| @@ -1,20 +1,18 @@ | |||
| /* @link https://utopia.fyi/type/calculator?c=320,16,1.125,1280,16,1.25,6,2,&s=0.75|0.5|0.25,1.5|2|3|4|6,s-l */ | |||
|
|
|||
| :root { | |||
There was a problem hiding this comment.
I believe this needs to stay where it is due to the @media(screen) block below changing --fluid-screen. Otherwise, the order of overrides is backwards.
There was a problem hiding this comment.
This was a miss from my side. Will take time to iterate upon this and fix it
|
Closing in favour of #421 |
similar to eslint/eslint#16467